content/renderer/input/input_event_filter_unittest.cc - Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/input/input_event_filter_unittest.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input/web_touch_event_traits.cc ('k') | content/renderer/input/main_thread_event_queue.cc » ('j') | content/renderer/input/main_thread_event_queue.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/input/input_event_filter_unittest.cc

diff --git a/content/renderer/input/input_event_filter_unittest.cc b/content/renderer/input/input_event_filter_unittest.cc

index c20bd9cc3f79a62e64c5c48a70bb446a74d34ad7..43cc6816fa4fdf37b54efc719a603fcc18faef72 100644

--- a/content/renderer/input/input_event_filter_unittest.cc

+++ b/content/renderer/input/input_event_filter_unittest.cc

@@ -429,6 +429,8 @@ TEST_F(InputEventFilterTest, NonBlockingTouch) {

InputEventDispatchType dispatch_type = base::get<2>(params);

EXPECT_EQ(kEvents[i].size, event->size);

+ kEvents[i].dispatchType =

+ WebInputEvent::DispatchType::ListenersNonBlockingPassive;

EXPECT_TRUE(memcmp(&kEvents[i], event, event->size) == 0);

EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN,

dispatch_type);

@@ -486,6 +488,8 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {

InputEventDispatchType dispatch_type = base::get<2>(params);

EXPECT_EQ(kEvents[0].size, event->size);

+ kEvents[0].dispatchType =

+ WebInputEvent::DispatchType::ListenersNonBlockingPassive;

EXPECT_TRUE(memcmp(&kEvents[0], event, event->size) == 0);

EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN,

dispatch_type);

@@ -505,6 +509,8 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {

InputEventDispatchType dispatch_type = base::get<2>(params);

EXPECT_EQ(kEvents[1].size, event->size);

+ kEvents[1].dispatchType =

+ WebInputEvent::DispatchType::ListenersNonBlockingPassive;

EXPECT_TRUE(memcmp(&kEvents[1], event, event->size) == 0);

EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING_NOTIFY_MAIN,

dispatch_type);