content/common/input/web_touch_event_traits.cc - Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/web_touch_event_traits.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue with reporting uma metrics Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input/web_input_event_traits.cc ('k') | content/renderer/input/main_thread_event_queue.cc » ('j') | content/renderer/input/main_thread_event_queue.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/web_touch_event_traits.cc

diff --git a/content/common/input/web_touch_event_traits.cc b/content/common/input/web_touch_event_traits.cc

index 175bf78ef41d8eb20457b8e874ec195845be86fb..77aa00f7069d08ba42a8e664264f922d5e44ef6c 100644

--- a/content/common/input/web_touch_event_traits.cc

+++ b/content/common/input/web_touch_event_traits.cc

@@ -52,7 +52,9 @@ void WebTouchEventTraits::ResetType(WebInputEvent::Type type,

WebTouchEvent* event) {

DCHECK(WebInputEvent::isTouchEventType(type));

event->type = type;

- event->cancelable = (type != WebInputEvent::TouchCancel);

+ event->dispatchType = type == WebInputEvent::TouchCancel

+ ? WebInputEvent::EventNonBlocking

+ : WebInputEvent::Blocking;

event->timeStampSeconds = timestamp_sec;

}