third_party/WebKit/Source/web/tests/TouchActionTest.cpp - Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TouchActionTest.cpp

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and non-const ref passed back Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebInputEventConversion.cpp ('k') | third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/TouchActionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TouchActionTest.cpp b/third_party/WebKit/Source/web/tests/TouchActionTest.cpp

index f9f5903a8327e4b9fdca58f17d11cc5dccd9aa5e..4d101cc7f9ca7998a4af7839eb0f736cda2e3285 100644

--- a/third_party/WebKit/Source/web/tests/TouchActionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TouchActionTest.cpp

@@ -329,7 +329,7 @@ void TouchActionTest::sendTouchEvent(WebView* webView, WebInputEvent::Type type,

WebTouchEvent webTouchEvent;

webTouchEvent.type = type;

if (type == WebInputEvent::TouchCancel)

- webTouchEvent.cancelable = false;

+ webTouchEvent.dispatchType = WebInputEvent::EventNonBlocking;

webTouchEvent.touchesLength = 1;

webTouchEvent.touches[0].state = (type == WebInputEvent::TouchStart ?

WebTouchPoint::StatePressed :