Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and non-const ref passed back Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/input_router_impl.cc
diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc
index 1af52e2f0a1402134debaf7653a92ad0c0a048c2..4c7f97b007106f1ea110bcfdf737ea926e37fa99 100644
--- a/content/browser/renderer_host/input/input_router_impl.cc
+++ b/content/browser/renderer_host/input/input_router_impl.cc
@@ -372,17 +372,7 @@ void InputRouterImpl::OfferToHandlers(const WebInputEvent& input_event,
if (OfferToClient(input_event, latency_info))
return;
- // Touch events should always indicate in the event whether they are
- // cancelable (respect ACK disposition) or not, except touchmove and
- // touchscollstarted.
bool should_block = WebInputEventTraits::ShouldBlockEventStream(input_event);
- if (WebInputEvent::isTouchEventType(input_event.type) &&
- input_event.type != WebInputEvent::TouchMove &&
- input_event.type != WebInputEvent::TouchScrollStarted) {
- const WebTouchEvent& touch = static_cast<const WebTouchEvent&>(input_event);
- DCHECK_EQ(should_block, touch.cancelable);
- }
-
OfferToRenderer(input_event, latency_info,
should_block
? InputEventDispatchType::DISPATCH_TYPE_BLOCKING
« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/input/touch_emulator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698