content/browser/renderer_host/input/input_router_impl.cc - Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 1888163003: Articulate the cancel behavior in the WebTouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/input/touch_emulator_unittest.cc » ('j') | content/browser/renderer_host/input/touch_emulator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl.cc

diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc

index 598e21747a928a468ffb9f3af15e7bbbcd347c06..c1d0220bdbb78c4ef9ee412914ce442bfb25a4c8 100644

--- a/content/browser/renderer_host/input/input_router_impl.cc

+++ b/content/browser/renderer_host/input/input_router_impl.cc

@@ -378,12 +378,6 @@ void InputRouterImpl::OfferToHandlers(const WebInputEvent& input_event,

? InputEventDispatchType::DISPATCH_TYPE_BLOCKING

: InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING);

- if (WebInputEvent::isTouchEventType(input_event.type) &&

- input_event.type != WebInputEvent::TouchMove) {

- const WebTouchEvent& touch = static_cast<const WebTouchEvent&>(input_event);

- DCHECK_EQ(should_block, touch.cancelable);

- }

// Generate a synthetic ack if the event was sent so it doesn't block.

if (!should_block) {

ProcessInputEventAck(