[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249
Committed: https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b
Cr-Commit-Position: refs/heads/master@{#387389}

[Devlin, 2016-04-14 18:53:51]

Description was changed from

==========
fix

BUG=
==========

to

==========
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249
==========

[Devlin, 2016-04-14 18:54:02]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2016-04-14 18:54:35]

Avi, mind taking a quick look?

https://codereview.chromium.org/1888133002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_action_button.mm (right):

https://codereview.chromium.org/1888133002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:173:
weakFactory_.GetWeakPtr();
D'oh. :(

[Avi (use Gerrit), 2016-04-14 19:08:31]

lgtm

https://codereview.chromium.org/1888133002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_action_button.mm (right):

https://codereview.chromium.org/1888133002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:173:
weakFactory_.GetWeakPtr();
On 2016/04/14 18:54:35, Devlin wrote:
> D'oh. :(

hahasob

[Devlin, 2016-04-14 19:10:22]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-04-14 19:10:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888133002/1

[commit-bot: I haz the power, 2016-04-14 19:16:53]

Description was changed from

==========
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249
==========

to

==========
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249
==========

[commit-bot: I haz the power, 2016-04-14 19:16:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 19:19:09]

Description was changed from

==========
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249
==========

to

==========
[Extensions UI Mac] Fix a bug with popped out actions' highlighted state

Fix a bug where popped out actions wouldn't clear their highlighted
state and add a couple of tests to protect against regression.

BUG=601249

Committed: https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b
Cr-Commit-Position: refs/heads/master@{#387389}
==========

[commit-bot: I haz the power, 2016-04-14 19:19:10]

Patchset 1 (id:??) landed as
https://crrev.com/e3a55f8fe3980f561aaba28e1a593d7ad020653b
Cr-Commit-Position: refs/heads/master@{#387389}