Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 188813004: Copy ui_overrides files from settings_overrides to preserve history (Closed)

Created:
6 years, 9 months ago by Mike Wittman
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Copy ui_overrides files from settings_overrides to preserve history This change is in support of later changes moving the bookmarks_ui manifest key from chrome_settings_overrides to chrome_ui_overrides. BUG=349049 R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + chrome/common/extensions/docs/templates/articles/ui_override.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/manifest_handlers/ui_overrides_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
PTAL The follow-on changes are in under review in https://codereview.chromium.org/183883033.
6 years, 9 months ago (2014-03-06 19:05:32 UTC) #1
not at google - send to devlin
I admit I find this a little bit strange. Since you're the person that authored ...
6 years, 9 months ago (2014-03-06 22:43:29 UTC) #2
Mike Wittman
On 2014/03/06 22:43:29, kalman wrote: > I admit I find this a little bit strange. ...
6 years, 9 months ago (2014-03-06 23:12:07 UTC) #3
Mike Wittman
6 years, 9 months ago (2014-03-07 18:10:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r255660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698