content/browser/frame_host/frame_tree_browsertest.cc - Issue 188813003: Update several browser_tests / content_browsertests to set iframes' name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_browsertest.cc

Issue 188813003: Update several browser_tests / content_browsertests to set iframes' name (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename iframe_id to iframe_name Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html ('k') | content/test/data/frame_tree/2-4.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/frame_tree_browsertest.cc

diff --git a/content/browser/frame_host/frame_tree_browsertest.cc b/content/browser/frame_host/frame_tree_browsertest.cc

index b384391f319c785fadc47c8185bd9dde94888c9e..150abff39ff9660ddf060cbf058f5f217224ee8d 100644

--- a/content/browser/frame_host/frame_tree_browsertest.cc

+++ b/content/browser/frame_host/frame_tree_browsertest.cc

@@ -83,7 +83,7 @@ IN_PROC_BROWSER_TEST_F(FrameTreeBrowserTest, FrameTreeShape2) {

ASSERT_EQ(2UL, root->child_at(2)->child_count());

EXPECT_EQ(1UL, root->child_at(2)->child_at(1)->child_count());

EXPECT_EQ(0UL, root->child_at(2)->child_at(1)->child_at(0)->child_count());

- EXPECT_STREQ("3-1-id",

+ EXPECT_STREQ("3-1-name",

root->child_at(2)->child_at(1)->child_at(0)->frame_name().c_str());

// Navigate to about:blank, which should leave only the root node of the frame