Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1888103002: Replace calls to deprecated CFX_{Wide,Byte}String::Empty() (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace calls to deprecated CFX_{Wide,Byte}String::Empty() Use the more standard name "clear()" instead. Committed: https://pdfium.googlesource.com/pdfium/+/774bdde253b8394aa2ac791e273508ff006d813a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -88 lines) Patch
M core/fpdftext/fpdf_text_int.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxcodec/codec/fx_codec_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/lgif/fx_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/include/fx_string.h View 2 chunks +0 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 11 chunks +13 lines, -13 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_targetimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jsapi.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/fxfa.h View 4 chunks +12 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, no functional change intended.
4 years, 8 months ago (2016-04-14 16:24:33 UTC) #2
dsinclair
lgtm
4 years, 8 months ago (2016-04-14 16:49:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888103002/1
4 years, 8 months ago (2016-04-14 16:49:26 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:49:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/774bdde253b8394aa2ac791e273508ff006d...

Powered by Google App Engine
This is Rietveld 408576698