Turn ElementsTransitionAndStore stub into a HydrogenCodeStub.

src/code-stubs.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 66 matching lines @@
   V(KeyedLoadElement)                    \
   V(ArrayNoArgumentConstructor)          \
   V(ArraySingleArgumentConstructor)      \
   V(ArrayNArgumentsConstructor)          \
   V(InternalArrayNoArgumentConstructor)  \
   V(InternalArraySingleArgumentConstructor)      \
   V(InternalArrayNArgumentsConstructor)  \
   V(KeyedStoreElement)                   \
   V(DebuggerStatement)                   \
   V(NameDictionaryLookup)                \
-  V(ElementsTransitionAndStore)          \
+  V(ElementsTransitionAndStoreStrict)    \
+  V(ElementsTransitionAndStoreNonStrict) \
   V(TransitionElementsKind)              \
   V(StoreArrayLiteralElement)            \
   V(StubFailureTrampoline)               \
   V(ArrayConstructor)                    \
   V(InternalArrayConstructor)            \
   V(ProfileEntryHook)                    \
   V(StoreGlobal)                         \
   /* IC Handler stubs */                 \
   V(LoadField)                           \
   V(KeyedLoadField)
@@ skipping 2105 matching lines @@
   Major MajorKey() { return ToBoolean; }
   int NotMissMinorKey() { return GetExtraICState(); }
 
   explicit ToBooleanStub(InitializationState init_state) :
     HydrogenCodeStub(init_state) {}
 
   Types types_;
 };
 
 
-class ElementsTransitionAndStoreStub : public PlatformCodeStub {
+class ElementsTransitionAndStoreStub : public HydrogenCodeStub {

[danno, 2013/07/10 09:52:37]

I kind of like the existing invariant that each stub has it's own descriptor and
there is always a 1-to-1 mapping. It think it would be cleaner if you make this
a superclass with two subclasses, one for strict and one for non-strict. then
you could override the script_mode() method (make it virtual), and everything
else should just work.

[Benedikt Meurer, 2013/07/10 12:23:09]

Done.

  public:
   ElementsTransitionAndStoreStub(ElementsKind from,
                                  ElementsKind to,
                                  bool is_jsarray,
                                  StrictModeFlag strict_mode,
                                  KeyedAccessStoreMode store_mode)
       : from_(from),
         to_(to),
         is_jsarray_(is_jsarray),
         strict_mode_(strict_mode),
-        store_mode_(store_mode) {}
+        store_mode_(store_mode) {
+    ASSERT(!IsFastHoleyElementsKind(from) || IsFastHoleyElementsKind(to));
+  }
+
+  ElementsKind from() const { return from_; }
+  ElementsKind to() const { return to_; }
+  bool is_jsarray() const { return is_jsarray_; }
+  StrictModeFlag strict_mode() const { return strict_mode_; }
+  KeyedAccessStoreMode store_mode() const { return store_mode_; }
+
+  virtual Handle<Code> GenerateCode();
+
+  virtual void InitializeInterfaceDescriptor(
+      Isolate* isolate,
+      CodeStubInterfaceDescriptor* descriptor);
 
  private:
-  class FromBits:       public BitField<ElementsKind,        0, 8> {};
-  class ToBits:         public BitField<ElementsKind,        8, 8> {};
-  class IsJSArrayBits:  public BitField<bool,                16, 1> {};
-  class StrictModeBits: public BitField<StrictModeFlag,      17, 1> {};
+  class FromBits:      public BitField<ElementsKind,          0, 8> {};
+  class ToBits:        public BitField<ElementsKind,          8, 8> {};
+  class IsJSArrayBits: public BitField<bool,                 16, 1> {};
   class StoreModeBits: public BitField<KeyedAccessStoreMode, 18, 4> {};
 
-  Major MajorKey() { return ElementsTransitionAndStore; }
-  int MinorKey() {
+  Major MajorKey() {
+    switch (strict_mode_) {
+      case kNonStrictMode: return ElementsTransitionAndStoreNonStrict;
+      case kStrictMode:    return ElementsTransitionAndStoreStrict;
+    }
+    UNREACHABLE();
+    return NoCache;
+  }
+  int NotMissMinorKey() {
     return FromBits::encode(from_) |
         ToBits::encode(to_) |
         IsJSArrayBits::encode(is_jsarray_) |
-        StrictModeBits::encode(strict_mode_) |
         StoreModeBits::encode(store_mode_);

[danno, 2013/07/10 09:52:37]

If you choose to do it this way, use the accessor functions.

[Benedikt Meurer, 2013/07/10 12:23:09]

Done.

   }
 
-  void Generate(MacroAssembler* masm);
-
   ElementsKind from_;
   ElementsKind to_;
   bool is_jsarray_;
   StrictModeFlag strict_mode_;
   KeyedAccessStoreMode store_mode_;
 
   DISALLOW_COPY_AND_ASSIGN(ElementsTransitionAndStoreStub);
 };
 
 
@@ skipping 62 matching lines @@
   int MinorKey() { return 0; }
 
   void Generate(MacroAssembler* masm);
 
   DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODE_STUBS_H_