Turn ElementsTransitionAndStore stub into a HydrogenCodeStub.

src/arm/code-stubs-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 240 matching lines @@
     Isolate* isolate,
     CodeStubInterfaceDescriptor* descriptor) {
   static Register registers[] = { r1, r2, r0 };
   descriptor->register_param_count_ = 3;
   descriptor->register_params_ = registers;
   descriptor->deoptimization_handler_ =
       FUNCTION_ADDR(StoreIC_MissFromStubFailure);
 }
 
 
+void ElementsTransitionAndStoreStub::InitializeInterfaceDescriptor(
+    Isolate* isolate,
+    CodeStubInterfaceDescriptor* descriptor) {
+  static Register registers[] = { r0, r3, r1, r2 };
+  descriptor->register_param_count_ = 4;
+  descriptor->register_params_ = registers;
+  switch (strict_mode_) {
+    case kNonStrictMode:
+      descriptor->deoptimization_handler_ = Runtime::FunctionForId(

[danno, 2013/07/10 09:52:37]

Yikes. In general, you should access members of the Stub during descriptor
initialization, this seems fragile. I would much prefer having one descriptor
per stub class and one stub class per descriptor .

[Benedikt Meurer, 2013/07/10 12:23:09]

Done.

+          Runtime::kElementsTransitionAndStoreNonStrict)->entry;
+      break;
+
+    case kStrictMode:
+      descriptor->deoptimization_handler_ = Runtime::FunctionForId(
+          Runtime::kElementsTransitionAndStoreStrict)->entry;
+      break;
+  }
+}
+
+
 #define __ ACCESS_MASM(masm)
 
 
 static void EmitIdenticalObjectComparison(MacroAssembler* masm,
                                           Label* slow,
                                           Condition cond);
 static void EmitSmiNonsmiComparison(MacroAssembler* masm,
                                     Register lhs,
                                     Register rhs,
                                     Label* lhs_not_nan,
@@ skipping 6928 matching lines @@
   __ bind(&fast_elements_case);
   GenerateCase(masm, FAST_ELEMENTS);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM