Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: cc/trees/property_tree_builder.cc

Issue 1888073002: cc : Delete unused properties in effect node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/property_tree_builder.h" 5 #include "cc/trees/property_tree_builder.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 // surface. So, we can leave the default value when we don't create a render 619 // surface. So, we can leave the default value when we don't create a render
620 // surface. 620 // surface.
621 if (should_create_render_surface) { 621 if (should_create_render_surface) {
622 // In this case, we will create a transform node, so it's safe to use the 622 // In this case, we will create a transform node, so it's safe to use the
623 // next available id from the transform tree as this effect node's 623 // next available id from the transform tree as this effect node's
624 // transform id. 624 // transform id.
625 node.data.transform_id = 625 node.data.transform_id =
626 data_from_ancestor.transform_tree->next_available_id(); 626 data_from_ancestor.transform_tree->next_available_id();
627 } 627 }
628 node.data.clip_id = data_from_ancestor.clip_tree_parent; 628 node.data.clip_id = data_from_ancestor.clip_tree_parent;
629 EffectNode* parent_node = data_for_children->effect_tree->Node(parent_id);
630 node.data.node_or_ancestor_has_background_filters =
631 parent_node->data.node_or_ancestor_has_background_filters ||
632 node.data.has_background_filters;
633 node.data.to_screen_opacity_is_animated =
634 parent_node->data.to_screen_opacity_is_animated || has_animated_opacity;
635 } else { 629 } else {
636 // Root render surface acts the unbounded and untransformed to draw content 630 // Root render surface acts the unbounded and untransformed to draw content
637 // into. Transform node created from root layer (includes device scale 631 // into. Transform node created from root layer (includes device scale
638 // factor) and clip node created from root layer (include viewports) applies 632 // factor) and clip node created from root layer (include viewports) applies
639 // to root render surface's content, but not root render surface itself. 633 // to root render surface's content, but not root render surface itself.
640 node.data.transform_id = kRootPropertyTreeNodeId; 634 node.data.transform_id = kRootPropertyTreeNodeId;
641 node.data.clip_id = kRootPropertyTreeNodeId; 635 node.data.clip_id = kRootPropertyTreeNodeId;
642 node.data.node_or_ancestor_has_background_filters =
643 node.data.has_background_filters;
644 node.data.to_screen_opacity_is_animated = has_animated_opacity;
645 } 636 }
646 data_for_children->effect_tree_parent = 637 data_for_children->effect_tree_parent =
647 data_for_children->effect_tree->Insert(node, parent_id); 638 data_for_children->effect_tree->Insert(node, parent_id);
648 layer->SetEffectTreeIndex(data_for_children->effect_tree_parent); 639 layer->SetEffectTreeIndex(data_for_children->effect_tree_parent);
649 if (should_create_render_surface) { 640 if (should_create_render_surface) {
650 data_for_children->compound_transform_since_render_target = 641 data_for_children->compound_transform_since_render_target =
651 gfx::Transform(); 642 gfx::Transform();
652 data_for_children->axis_align_since_render_target = true; 643 data_for_children->axis_align_since_render_target = true;
653 } 644 }
654 return should_create_render_surface; 645 return should_create_render_surface;
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1005 if (SkColorGetA(color) != 255) 996 if (SkColorGetA(color) != 255)
1006 color = SkColorSetA(color, 255); 997 color = SkColorSetA(color, 255);
1007 BuildPropertyTreesTopLevelInternal( 998 BuildPropertyTreesTopLevelInternal(
1008 root_layer, page_scale_layer, inner_viewport_scroll_layer, 999 root_layer, page_scale_layer, inner_viewport_scroll_layer,
1009 outer_viewport_scroll_layer, overscroll_elasticity_layer, 1000 outer_viewport_scroll_layer, overscroll_elasticity_layer,
1010 elastic_overscroll, page_scale_factor, device_scale_factor, viewport, 1001 elastic_overscroll, page_scale_factor, device_scale_factor, viewport,
1011 device_transform, property_trees, color); 1002 device_transform, property_trees, color);
1012 } 1003 }
1013 1004
1014 } // namespace cc 1005 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698