Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1888053002: PPC: [Interpreter] Make dispatch table point to code entry instead of code objects. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Make dispatch table point to code entry instead of code objects. Port 0c05e02f25912c0ce510dac3077be3f72728aa34 Original commit message: Modifies Ignition to store code entry addresses in the dispatch table rather than code objects. This allows the interpreter to avoid calculating the code entry address from the code object on every dispatch and provides a ~5-7% performance improvement on Octane with Ignition. This change adds ArchOpcode::kArchTailCallAddress to TurboFan to enable tail call dispatch using these code addresses. It also adds a Dispatch linkage creator (distinct from the stub linkage type used previously) to allow targetting a code address target (which will diverge further from the stub linkage type when we remove the context machine register in Ignition). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/6c702283ac9df1cb5f577133bda722defd429a1d Cr-Commit-Position: refs/heads/master@{#35501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-14 15:01:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888053002/1
4 years, 8 months ago (2016-04-14 15:01:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 15:20:42 UTC) #5
JoranSiu
On 2016/04/14 15:20:42, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-14 17:33:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888053002/1
4 years, 8 months ago (2016-04-14 17:45:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 17:48:11 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 17:48:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c702283ac9df1cb5f577133bda722defd429a1d
Cr-Commit-Position: refs/heads/master@{#35501}

Powered by Google App Engine
This is Rietveld 408576698