Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1888043004: X87: Simplify IC interfaces. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Simplify IC interfaces. port 911a5768dcf7bc8a5cbfb8fca9a7e887af42296f (r35301) original commit message: BUG= Committed: https://crrev.com/459d79ac1bbee6881e37aa4a05c9845cb4181a3d Cr-Commit-Position: refs/heads/master@{#35512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-15 06:52:54 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-15 07:07:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888043004/1
4 years, 8 months ago (2016-04-15 09:20:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 09:45:23 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 09:46:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/459d79ac1bbee6881e37aa4a05c9845cb4181a3d
Cr-Commit-Position: refs/heads/master@{#35512}

Powered by Google App Engine
This is Rietveld 408576698