third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl - Issue 1888023002: Add a counter for the |remote| member of MediaStreamTrack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

Issue 1888023002: Add a counter for the |remote| member of MediaStreamTrack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove |remote| and |readonly| members of MediaStreamTrack Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/UseCounter.h ('K') | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

index fe2c68a9ad593089eb71d992f58184592867db0d..cec41c235e16e92b6471c7db4142d7407ad819d6 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

+++ b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl

@@ -31,7 +31,8 @@

readonly attribute DOMString label;

attribute boolean enabled;

readonly attribute boolean muted;

- readonly attribute boolean remote;

+ [MeasureAs=MediaStreamTrackRemote] readonly attribute boolean remote;

+ [MeasureAs=MediaStreamTrackReadonly] readonly attribute boolean _readonly;

Guido Urdaneta 2016/04/15 08:19:17 I don't think you should be adding this attribute,

hta - Chromium 2016/04/15 10:27:36 Oops - I missed that. Its absence means that we ne

readonly attribute DOMString readyState;

[CallWith=ExecutionContext, RaisesException, DeprecateAs=MediaStreamTrackGetSources] static void getSources(MediaStreamTrackSourcesCallback callback);