Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1888023002: Add a counter for the |remote| member of MediaStreamTrack (Closed)

Created:
4 years, 8 months ago by Taylor.Hoon
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is the first step towards the deprecation and removal of this attribute. BUG=598704 Committed: https://crrev.com/c13ddaa06b8eb33072db24d79f9d338c8ac0213d Cr-Commit-Position: refs/heads/master@{#388171}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove |remote| and |readonly| members of MediaStreamTrack #

Total comments: 3

Patch Set 3 : Add a counter for the |remote| member of MediaStreamTrack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (15 generated)
Taylor.Hoon
Now I begin the process for removing |remote| and |readonly| members of MediaStreamTrack. For that, ...
4 years, 8 months ago (2016-04-14 13:20:43 UTC) #3
hta - Chromium
Looks good, but please complete the CL: run update_use_counter_feature_enum.py in chromium/src/tools/metrics/histograms/ to update the UMA ...
4 years, 8 months ago (2016-04-14 13:30:21 UTC) #4
Guido Urdaneta
Note also that the description of the CL does not match its content since you ...
4 years, 8 months ago (2016-04-14 13:33:38 UTC) #6
Taylor.Hoon
On 2016/04/14 13:30:21, hta - Chromium wrote: > Looks good, but please complete the CL: ...
4 years, 8 months ago (2016-04-15 08:12:50 UTC) #8
hta - Chromium
lgtm I think you have to get some more approvals, though.
4 years, 8 months ago (2016-04-15 08:18:57 UTC) #9
Guido Urdaneta
https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl File third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl (right): https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl#newcode35 third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl:35: [MeasureAs=MediaStreamTrackReadonly] readonly attribute boolean _readonly; I don't think you ...
4 years, 8 months ago (2016-04-15 08:19:17 UTC) #10
Taylor.Hoon
On 2016/04/15 08:19:17, Guido Urdaneta wrote: > https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl > File third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl (right): > > https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl#newcode35 ...
4 years, 8 months ago (2016-04-15 08:37:03 UTC) #11
Guido Urdaneta
On 2016/04/15 08:37:03, Taylor.Hoon wrote: > On 2016/04/15 08:19:17, Guido Urdaneta wrote: > > > ...
4 years, 8 months ago (2016-04-15 08:55:21 UTC) #13
hta - Chromium
Notes.... https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1888023002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1126 third_party/WebKit/Source/core/frame/UseCounter.h:1126: MediaStreamTrackRemote = 1306, Note: People add new numbers ...
4 years, 8 months ago (2016-04-15 10:27:37 UTC) #14
hta - Chromium
lgtm
4 years, 8 months ago (2016-04-18 06:53:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888023002/40001
4 years, 8 months ago (2016-04-18 06:54:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/169698)
4 years, 8 months ago (2016-04-18 07:02:44 UTC) #19
haraken
core/ LGTM You need to get an LG for histograms.xml though.
4 years, 8 months ago (2016-04-18 07:03:34 UTC) #20
Guido Urdaneta
isherman: please review histograms.xml
4 years, 8 months ago (2016-04-18 19:17:46 UTC) #23
Ilya Sherman
histograms.xml lgtm
4 years, 8 months ago (2016-04-19 00:25:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888023002/40001
4 years, 8 months ago (2016-04-19 00:27:46 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/207177)
4 years, 8 months ago (2016-04-19 04:26:50 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888023002/40001
4 years, 8 months ago (2016-04-19 05:53:18 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-19 09:39:49 UTC) #32
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 09:40:45 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c13ddaa06b8eb33072db24d79f9d338c8ac0213d
Cr-Commit-Position: refs/heads/master@{#388171}

Powered by Google App Engine
This is Rietveld 408576698