Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1887983006: Support output_dir on GN Windows. (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support output_dir on GN Windows. This hooks up the new output directory support to the Windows toolchain in GN. Also removes some obsolete TODOs about manifest support (this ended up working differently). Committed: https://crrev.com/c990f15ee1d7024af4653801414d77b84f12294d Cr-Commit-Position: refs/heads/master@{#387654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M build/toolchain/win/BUILD.gn View 4 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
4 years, 8 months ago (2016-04-15 17:37:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887983006/1
4 years, 8 months ago (2016-04-15 17:37:59 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-15 18:23:18 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 18:24:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887983006/1
4 years, 8 months ago (2016-04-15 18:25:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 18:30:46 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 18:32:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c990f15ee1d7024af4653801414d77b84f12294d
Cr-Commit-Position: refs/heads/master@{#387654}

Powered by Google App Engine
This is Rietveld 408576698