Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1887983005: Revert of Remove WallpaperManager dependency on Cryptohome. (Closed)

Created:
4 years, 8 months ago by ilja
Modified:
4 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove WallpaperManager dependency on Cryptohome. (patchset #7 id:120001 of https://codereview.chromium.org/1886653002/ ) Reason for revert: crbug.com/603655 Original issue's description: > Remove WallpaperManager dependency on Cryptohome. > > This Cl adds wallpaper file names hashing to WallpaperManager itself, > removing dependency on cryptohome. No more asynchronous calls. > > BUG=462823 > TEST=manual > > Committed: https://crrev.com/81e10078a524522e862dd33ebdceaf64f4ebeba1 > Cr-Commit-Position: refs/heads/master@{#387235} TBR=dkrahn@chromium.org,bshe@chromium.org,alemate@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462823 Committed: https://crrev.com/180168420f3253d9dedb528b2e14fb9d01739726 Cr-Commit-Position: refs/heads/master@{#387443}

Patch Set 1 #

Messages

Total messages: 12 (4 generated)
ilja
Created Revert of Remove WallpaperManager dependency on Cryptohome.
4 years, 8 months ago (2016-04-14 21:15:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887983005/1
4 years, 8 months ago (2016-04-14 21:16:06 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-14 21:16:08 UTC) #4
hshi1
lgtm
4 years, 8 months ago (2016-04-14 21:19:57 UTC) #6
Alexander Alekseev
lgtm
4 years, 8 months ago (2016-04-14 22:00:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887983005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887983005/1
4 years, 8 months ago (2016-04-14 22:14:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 22:15:33 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:18:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/180168420f3253d9dedb528b2e14fb9d01739726
Cr-Commit-Position: refs/heads/master@{#387443}

Powered by Google App Engine
This is Rietveld 408576698