Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1887943002: Convert track tests from video-test.js to testharness.js based (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track tests from video-test.js to testharness.js based Cleaning up track-cue-nothing* and track-cue-rendering* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/e302d364c9bb07162b7902d88386c06629a91e39 Cr-Commit-Position: refs/heads/master@{#388761}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -389 lines) Patch
M third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html View 1 1 chunk +46 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html View 1 chunk +13 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-cue-rendering-empty-cue-crash-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-first-line-box.html View 1 chunk +16 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-cue-rendering-first-line-box-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html View 1 chunk +63 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html View 1 1 chunk +24 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Srirama
PTAL
4 years, 8 months ago (2016-04-14 07:26:27 UTC) #3
mlamouri (slow - plz ping)
https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html File third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html (right): https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html#newcode37 third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html:37: assert_equals(textTrackDisplayElement(video, "display").innerText, cueText); It seems that this could be ...
4 years, 8 months ago (2016-04-19 15:16:29 UTC) #4
Srirama
https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html File third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html (right): https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html#newcode37 third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html:37: assert_equals(textTrackDisplayElement(video, "display").innerText, cueText); On 2016/04/19 15:16:29, Mounir Lamouri wrote: ...
4 years, 8 months ago (2016-04-19 16:31:02 UTC) #5
mlamouri (slow - plz ping)
lgtm
4 years, 8 months ago (2016-04-21 12:27:52 UTC) #6
philipj_slow
https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html File third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html (right): https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html#newcode48 third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html:48: video.currentTime = 0.5; Use info[0] here?
4 years, 8 months ago (2016-04-21 12:46:16 UTC) #7
philipj_slow
lgtm % nits https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html File third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html (right): https://codereview.chromium.org/1887943002/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html#newcode2 third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html:2: <title>Test that Line Height of cue ...
4 years, 8 months ago (2016-04-21 12:48:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887943002/20001
4 years, 8 months ago (2016-04-21 13:02:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 14:00:30 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:34:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e302d364c9bb07162b7902d88386c06629a91e39
Cr-Commit-Position: refs/heads/master@{#388761}

Powered by Google App Engine
This is Rietveld 408576698