Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 1887913005: add keyboard overlay entry for taking window screenshot (Closed)

Created:
4 years, 8 months ago by Qiang(Joe) Xu
Modified:
4 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add keyboard overlay entry for taking window screenshot When the top row keys are treated as function keys. related review link: https://codereview.chromium.org/1827323002/ BUG= Committed: https://crrev.com/f49ac9d6d60cb84bdd4faf9975229e41c5e59960 Cr-Commit-Position: refs/heads/master@{#387933}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Qiang(Joe) Xu
4 years, 8 months ago (2016-04-16 01:58:55 UTC) #4
xiyuan
lgtm
4 years, 8 months ago (2016-04-18 16:02:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887913005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887913005/20001
4 years, 8 months ago (2016-04-18 16:25:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 17:22:15 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:23:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f49ac9d6d60cb84bdd4faf9975229e41c5e59960
Cr-Commit-Position: refs/heads/master@{#387933}

Powered by Google App Engine
This is Rietveld 408576698