Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1887883006: Fix Set.from which still had a generic type on the incoming Iterable. (Closed)

Created:
4 years, 8 months ago by floitsch
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Set.from which still had a generic type on the incoming Iterable. Follow-up fix for http://dartbug.com/21731 Also see https://codereview.chromium.org/838463002/ R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/b19e00c2d4a54ed759e69491148206d1cc7a572f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M sdk/lib/collection/linked_hash_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/set_test.dart View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 8 months ago (2016-04-16 00:15:05 UTC) #2
Lasse Reichstein Nielsen
lgtm
4 years, 7 months ago (2016-04-27 20:37:17 UTC) #3
floitsch
4 years, 7 months ago (2016-04-28 13:01:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b19e00c2d4a54ed759e69491148206d1cc7a572f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698