Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887853003: Add switch for mojo tests (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add switch for mojo tests Hopefully this makes them start working. BUG=594600 TEST=none R=dpranke@chromium.org Committed: https://crrev.com/bee374bf24e72d354da2d76c668668f90589b8a1 Cr-Commit-Position: refs/heads/master@{#387341}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M testing/buildbot/chromium.mojo.json View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
sky
https://codereview.chromium.org/1887853003/diff/1/testing/buildbot/chromium.mojo.json File testing/buildbot/chromium.mojo.json (right): https://codereview.chromium.org/1887853003/diff/1/testing/buildbot/chromium.mojo.json#newcode23 testing/buildbot/chromium.mojo.json:23: "--use-x11-test-config" This switch isn't used for win, so only ...
4 years, 8 months ago (2016-04-14 15:55:42 UTC) #1
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-14 16:19:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887853003/1
4 years, 8 months ago (2016-04-14 16:20:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 17:00:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 17:01:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bee374bf24e72d354da2d76c668668f90589b8a1
Cr-Commit-Position: refs/heads/master@{#387341}

Powered by Google App Engine
This is Rietveld 408576698