Mac 420 video: Add core profile shaders

Mac 420 video: Add core profile shaders

BUG=535214
Committed: https://crrev.com/048fcf6d17a1f9404774b278386dc4e98482baf4
Cr-Commit-Position: refs/heads/master@{#387192}

[ccameron, 2016-04-13 23:40:15]

Description was changed from

==========
Mac 420 video: Add core profile shaders

BUG=
==========

to

==========
Mac 420 video: Add core profile shaders

BUG= 535214
==========

[ccameron, 2016-04-13 23:40:15]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2016-04-13 23:40:34]

The video subset of WebGL conformance passes in core profile mode with this.

[Ken Russell (switch to Gerrit), 2016-04-14 00:01:15]

Excellent! LGTM.

https://codereview.chromium.org/1887843003/diff/1/ui/gl/gl_image_io_surface.mm
File ui/gl/gl_image_io_surface.mm (right):

https://codereview.chromium.org/1887843003/diff/1/ui/gl/gl_image_io_surface.m...
ui/gl/gl_image_io_surface.mm:41: "#define varying out\n";
I suggest naming these ATTRIBUTE and VARYING and replacing them in the shaders
so it's clear that they're macros.

[ccameron, 2016-04-14 00:25:13]

Thanks!

https://codereview.chromium.org/1887843003/diff/1/ui/gl/gl_image_io_surface.mm
File ui/gl/gl_image_io_surface.mm (right):

https://codereview.chromium.org/1887843003/diff/1/ui/gl/gl_image_io_surface.m...
ui/gl/gl_image_io_surface.mm:41: "#define varying out\n";
On 2016/04/14 00:01:15, Ken Russell wrote:
> I suggest naming these ATTRIBUTE and VARYING and replacing them in the shaders
> so it's clear that they're macros.

Good point -- done.

[ccameron, 2016-04-14 00:25:18]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-04-14 00:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1887843003/#ps20001
(title: "Incorproate review feedback")

[commit-bot: I haz the power, 2016-04-14 00:25:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887843003/20001

[commit-bot: I haz the power, 2016-04-14 01:20:55]

Description was changed from

==========
Mac 420 video: Add core profile shaders

BUG= 535214
==========

to

==========
Mac 420 video: Add core profile shaders

BUG= 535214
==========

[commit-bot: I haz the power, 2016-04-14 01:20:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 01:22:28]

Description was changed from

==========
Mac 420 video: Add core profile shaders

BUG= 535214
==========

to

==========
Mac 420 video: Add core profile shaders

BUG= 535214

Committed: https://crrev.com/048fcf6d17a1f9404774b278386dc4e98482baf4
Cr-Commit-Position: refs/heads/master@{#387192}
==========

[commit-bot: I haz the power, 2016-04-14 01:22:29]

Patchset 2 (id:??) landed as
https://crrev.com/048fcf6d17a1f9404774b278386dc4e98482baf4
Cr-Commit-Position: refs/heads/master@{#387192}