Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4121)

Unified Diff: base/android/javatests/src/org/chromium/base/ObserverListTest.java

Issue 188783002: ObserverList.removeObserver() should not return true when null is being removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@optimize_remove_observer
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/ObserverList.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/javatests/src/org/chromium/base/ObserverListTest.java
diff --git a/base/android/javatests/src/org/chromium/base/ObserverListTest.java b/base/android/javatests/src/org/chromium/base/ObserverListTest.java
index cb09c2c60c0707142c610bb73676831cd7fbc07c..f999168c53f7f1ee4edec0460d68055957c2491c 100644
--- a/base/android/javatests/src/org/chromium/base/ObserverListTest.java
+++ b/base/android/javatests/src/org/chromium/base/ObserverListTest.java
@@ -245,5 +245,11 @@ public class ObserverListTest extends InstrumentationTestCase {
assertFalse(observerList.removeObserver(new Object()));
assertTrue(observerList.removeObserver(b));
assertFalse(observerList.removeObserver(null));
+
+ // If we remove an object while iterating, it will be replaced by 'null'.
+ observerList.addObserver(a);
+ Iterator<Object> iterator = observerList.iterator();
+ assertTrue(observerList.removeObserver(a));
+ assertFalse(observerList.removeObserver(null));
}
}
« no previous file with comments | « base/android/java/src/org/chromium/base/ObserverList.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698