Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1887823002: PPC: [Atomics] code stubs for atomic operations (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Atomics] code stubs for atomic operations Port 5e9ddf6ce4b698cb3112bd349ca5206cfada1437 Original commit message: * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 R=binji@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=v8:4614 LOG=N Committed: https://crrev.com/89e9819cbe0c3648a59ec9fcf328aaf3b735027d Cr-Commit-Position: refs/heads/master@{#35462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -0 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +181 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-13 22:30:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887823002/1
4 years, 8 months ago (2016-04-13 22:31:10 UTC) #3
binji
On 2016/04/13 22:30:49, MTBrandyberry wrote: > PTAL Looks good, please note https://codereview.chromium.org/1883903002/ as well, which ...
4 years, 8 months ago (2016-04-13 22:36:04 UTC) #4
binji
On 2016/04/13 22:36:04, binji wrote: > On 2016/04/13 22:30:49, MTBrandyberry wrote: > > PTAL > ...
4 years, 8 months ago (2016-04-13 22:48:13 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 22:49:12 UTC) #7
john.yan
lgtm
4 years, 8 months ago (2016-04-13 23:37:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887823002/1
4 years, 8 months ago (2016-04-14 02:01:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 02:03:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:05:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e9819cbe0c3648a59ec9fcf328aaf3b735027d
Cr-Commit-Position: refs/heads/master@{#35462}

Powered by Google App Engine
This is Rietveld 408576698