Add functions to clean URLs from the activity log

chrome/browser/extensions/activity_log/fullstream_ui_policy.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/json/json_reader.h"
@@ skipping 79 matching lines @@
     if (action.args()) {
       statement.BindString(4, Util::Serialize(action.args()));
     }
     std::string page_url_string = action.SerializePageUrl();
     if (!page_url_string.empty()) {
       statement.BindString(5, page_url_string);
     }
     if (!action.page_title().empty()) {
       statement.BindString(6, action.page_title());
     }
-    std::string arg_url_string = action.SerializePageUrl();
+    std::string arg_url_string = action.SerializeArgUrl();
     if (!arg_url_string.empty()) {
-      statement.BindString(5, arg_url_string);
+      statement.BindString(7, arg_url_string);
     }
     if (action.other()) {
       statement.BindString(8, Util::Serialize(action.other()));
     }
 
     if (!statement.Run()) {
       LOG(ERROR) << "Activity log database I/O failed: " << sql_str;
       return false;
     }
   }
@@ skipping 67 matching lines @@
         LOG(WARNING) << "Unable to parse other: '" << query.ColumnString(7)
                      << "'";
       }
     }
 
     actions->push_back(action);
   }
   return actions.Pass();
 }
 
+void FullStreamUIPolicy::DoRemoveURLs(const std::vector<GURL>& restrict_urls) {
+  sql::Connection* db = GetDatabaseConnection();
+  if (!db) {
+    LOG(ERROR) << "Unable to connect to database";
+    return;
+  }
+

[mvrable, 2013/08/26 18:22:42]

Add a
  activity_database()->AdviseFlush(ActivityDatabase::kFlushImmediately);
to the start of this method so that actions queued in memory are covered by the
history clearing.

[karenlees, 2013/08/26 22:58:36]

Done.

+  // If no restrictions then then all URLs need to be removed.
+  if (restrict_urls.empty()) {
+    sql::Statement statement;
+    std::string sql_str = base::StringPrintf(
+        "UPDATE %s SET page_url=NULL,page_title=NULL,arg_url=NULL",
+        kTableName);
+    statement.Assign(db->GetCachedStatement(
+        sql::StatementID(SQL_FROM_HERE), sql_str.c_str()));
+
+    if (!statement.Run()) {
+      LOG(ERROR) << "Removing URLs from database failed: "
+                 << statement.GetSQLStatement();
+    }
+    return;
+  }
+
+  // If URLs are specified then restrict to only those URLs.
+  for (uint32_t i = 0; i < restrict_urls.size(); ++i) {

[mvrable, 2013/08/26 20:38:50]

size_t

[karenlees, 2013/08/26 22:58:36]

Done.

+    if (!restrict_urls[i].is_valid()) {
+      continue;
+    }
+    DLOG(INFO) << "Removing URL " << restrict_urls[i].spec();
+
+    sql::Statement statement;
+    std::string sql_str = base::StringPrintf(
+      "UPDATE %s SET page_url=NULL,page_title=NULL,arg_url=NULL "
+      "WHERE page_url=? OR arg_url=?",
+      kTableName);
+    statement.Assign(db->GetCachedStatement(
+        sql::StatementID(SQL_FROM_HERE), sql_str.c_str()));
+    statement.BindString(0, restrict_urls[i].spec());
+    statement.BindString(1, restrict_urls[i].spec());
+
+    if (!statement.Run()) {
+      LOG(ERROR) << "Removing URL from database failed: "
+                 << statement.GetSQLStatement();
+    }
+  }
+}
+
 void FullStreamUIPolicy::OnDatabaseFailure() {
   queued_actions_.clear();
 }
 
 void FullStreamUIPolicy::OnDatabaseClose() {
   delete this;
 }
 
 void FullStreamUIPolicy::Close() {
   // The policy object should have never been created if there's no DB thread.
   DCHECK(BrowserThread::IsMessageLoopValid(BrowserThread::DB));
   ScheduleAndForget(activity_database(), &ActivityDatabase::Close);
 }
 
 // Get data as a set of key-value pairs.  The keys are policy-specific.
 void FullStreamUIPolicy::ReadData(
     const std::string& extension_id,
     const int day,
     const Callback<void(scoped_ptr<Action::ActionVector>)>& callback) {
   BrowserThread::PostTaskAndReplyWithResult(
       BrowserThread::DB,
       FROM_HERE,
       base::Bind(&FullStreamUIPolicy::DoReadData,
                  base::Unretained(this),
                  extension_id,
                  day),
       callback);
 }
 
+void FullStreamUIPolicy::RemoveURLs(const std::vector<GURL>& restrict_urls) {
+  BrowserThread::PostTask(

[mvrable, 2013/08/26 20:38:50]

ScheduleAndForget should be able to do the same as postTask but with slightly
simpler code.

+      BrowserThread::DB,
+      FROM_HERE,
+      base::Bind(&FullStreamUIPolicy::DoRemoveURLs,
+                 base::Unretained(this),
+                 restrict_urls));
+}
+
 scoped_refptr<Action> FullStreamUIPolicy::ProcessArguments(
     scoped_refptr<Action> action) const {
   return action;
 }
 
 void FullStreamUIPolicy::ProcessAction(scoped_refptr<Action> action) {
   // TODO(mvrable): Right now this argument stripping updates the Action object
   // in place, which isn't good if there are other users of the object.  When
   // database writing is moved to policy class, the modifications should be
   // made locally.
   action = ProcessArguments(action);
   ScheduleAndForget(this, &FullStreamUIPolicy::QueueAction, action);
 }
 
 void FullStreamUIPolicy::QueueAction(scoped_refptr<Action> action) {
   if (activity_database()->is_db_valid()) {
     queued_actions_.push_back(action);
     activity_database()->AdviseFlush(queued_actions_.size());
   }
 }
 
 }  // namespace extensions