Add functions to clean URLs from the activity log

chrome/browser/extensions/activity_log/counting_policy.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_COUNTING_POLICY_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_COUNTING_POLICY_H_
 
 #include <string>
 
 #include "base/containers/hash_tables.h"
@@ skipping 18 matching lines @@
           <void(scoped_ptr<Action::ActionVector>)>& callback) OVERRIDE;
 
   virtual void Close() OVERRIDE;
 
   // Gets or sets the amount of time that old records are kept in the database.
   const base::TimeDelta& retention_time() const { return retention_time_; }
   void set_retention_time(const base::TimeDelta& delta) {
     retention_time_ = delta;
   }
 
+  // Clean the URL data stored for this policy.
+  virtual void RemoveURLs(const std::vector<GURL>&);

[mvrable, 2013/08/26 20:38:50]

virtual void RemoveURLs(const std::vector<GURL>&) OVERRIDE;

[karenlees, 2013/08/26 22:58:36]

Done.

+
   // The main database table, and the name for a read-only view that
   // decompresses string values for easier parsing.
   static const char* kTableName;
   static const char* kReadViewName;
 
  protected:
   // The ActivityDatabase::Delegate interface.  These are always called from
   // the database thread.
   virtual bool InitDatabase(sql::Connection* db) OVERRIDE;
   virtual bool FlushDatabase(sql::Connection* db) OVERRIDE;
@@ skipping 10 matching lines @@
   // Adds an Action to those to be written out; this is an internal method used
   // by ProcessAction and is called on the database thread.
   void QueueAction(scoped_refptr<Action> action);
 
   // Internal method to read data from the database; called on the database
   // thread.
   scoped_ptr<Action::ActionVector> DoReadData(
       const std::string& extension_id,
       const int days_ago);
 
+  // The implementation of RemoveURLs; this must only run on the database
+  // thread.
+  virtual void DoRemoveURLs(const std::vector<GURL>& restrict_urls);

[mvrable, 2013/08/26 20:38:50]

Doesn't need to be virtual since the method is private.

[karenlees, 2013/08/26 22:58:36]

Done - but should I make it protected instead, incase this gets subclassed?

[mvrable, 2013/08/27 17:17:37]

Personal opinion: it doesn't need to be as we can always go back later and make
it protected virtual if we need to subclass.  But I don't have a strong feeling
on this.

+
   // Cleans old records from the activity log database.
   bool CleanOlderThan(sql::Connection* db, const base::Time& cutoff);
 
   // Cleans unused interned strings from the database.  This should be run
   // after deleting rows from the main log table to clean out stale values.
   bool CleanStringTables(sql::Connection* db);
 
   // API calls for which complete arguments should be logged.
   std::set<std::string> api_arg_whitelist_;
 
@@ skipping 25 matching lines @@
   base::Time last_database_cleaning_time_;
 
   friend class CountingPolicyTest;
   FRIEND_TEST_ALL_PREFIXES(CountingPolicyTest, MergingAndExpiring);
   FRIEND_TEST_ALL_PREFIXES(CountingPolicyTest, StringTableCleaning);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_COUNTING_POLICY_H_