Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 18878007: Omnibox: Make the Controller Reorder Matches for Inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index ee072857dad2292a79c1a6b81241cc550df38af0..19c4ef6965b3eb3b16c4edd4c065f9405412502b 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -137,6 +137,29 @@ class OmniboxFieldTrial {
AutocompleteInput::PageClassification current_page_classification,
DemotionMultipliers* demotions_by_type);
+ // ---------------------------------------------------------
+ // For the ReorderForLegalDefaultMatch experiment that's part of the
+ // bundled omnibox field trial.
+
+ // Returns true if the omnibox will reorder matches, in the provided
+ // |current_page_classification| context so that a match that's allowed to
+ // be the default match will appear first. This means AutocompleteProviders
+ // can score matches however they desire without regard to making sure the
+ // top match when all the matches from all providers are merged is a legal
+ // default match.
+ static bool ReorderForLegalDefaultMatch(
+ AutocompleteInput::PageClassification current_page_classification);
+
+ // ---------------------------------------------------------
+ // Exposed publicly for the sake of unittests.
+ static const char kBundledExperimentFieldTrialName[];
+ // Rule names used by the bundled experiment.
+ static const char kSearchHistoryRule[];
+ static const char kDemoteByTypeRule[];
+ static const char kReorderForLegalDefaultMatchRule[];
+ // Rule values.
+ static const char kReorderForLegalDefaultMatchRuleEnabled[];
+
private:
friend class OmniboxFieldTrialTest;

Powered by Google App Engine
This is Rietveld 408576698