Omnibox: Make the Controller Reorder Matches for Inlining

chrome/browser/omnibox/omnibox_field_trial.cc

Index: chrome/browser/omnibox/omnibox_field_trial.cc
diff --git a/chrome/browser/omnibox/omnibox_field_trial.cc b/chrome/browser/omnibox/omnibox_field_trial.cc
index 83b9143b73f6ac2e006944d6bfd49dc5a302a5c9..65812f753a18f3d7bda6ae3c686c74391b5bfc83 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.cc
+++ b/chrome/browser/omnibox/omnibox_field_trial.cc
@@ -22,10 +22,6 @@ const char kHUPCreateShorterMatchFieldTrialName[] =
     "OmniboxHUPCreateShorterMatch";
 const char kStopTimerFieldTrialName[] = "OmniboxStopTimer";
 const char kShortcutsScoringFieldTrialName[] = "OmniboxShortcutsScoring";
-const char kBundledExperimentFieldTrialName[] = "OmniboxBundledExperimentV1";
-
-// Rule names used by the bundled experiment.
-const char kSearchHistoryRule[] = "SearchHistory";
 
 // The autocomplete dynamic field trial name prefix.  Each field trial is
 // configured dynamically and is retrieved automatically by Chrome during
@@ -233,6 +229,22 @@ bool OmniboxFieldTrial::SearchHistoryDisable(
       kSearchHistoryRule, current_page_classification) == "Disable";
 }
 
+bool OmniboxFieldTrial::ReorderForLegalDefaultMatch(
+    AutocompleteInput::PageClassification current_page_classification) {
+  return OmniboxFieldTrial::GetValueForRuleInContext(
+      kReorderForLegalDefaultMatchRule, current_page_classification) ==
+      kReorderForLegalDefaultMatchRuleEnabled;
+}
+
+// static (just like everything else in this file)

[Peter Kasting, 2013/08/09 21:59:34]

Nit: I wouldn't just write this here, since no one else does.  If you want to
put it on everything in the file, or (less good) on top of the file, fine,
otherwise I'd just leave it off entirely.

[Mark P, 2013/08/09 22:24:11]

Okay, dropped.

+const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
+    "OmniboxBundledExperimentV1";
+const char OmniboxFieldTrial::kSearchHistoryRule[] = "SearchHistory";
+const char OmniboxFieldTrial::kReorderForLegalDefaultMatchRule[] =
+    "ReorderForLegalDefaultMatch";
+const char OmniboxFieldTrial::kReorderForLegalDefaultMatchRuleEnabled[] =
+    "ReorderForLegalDefaultMatch";
+
 // Background and implementation details:
 //
 // Each experiment group in any field trial can come with an optional set of