Omnibox: Make the Controller Reorder Matches for Inlining

chrome/browser/autocomplete/history_url_provider.cc

Index: chrome/browser/autocomplete/history_url_provider.cc
diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc
index 18e8f27a3830321757209d55d5fdec81f7b5717a..e8be17134412cb9f4b6110415f0294ec4a75aa36 100644
--- a/chrome/browser/autocomplete/history_url_provider.cc
+++ b/chrome/browser/autocomplete/history_url_provider.cc
@@ -349,6 +349,7 @@ AutocompleteMatch HistoryURLProvider::SuggestExactInput(
     match.fill_into_edit =
         AutocompleteInput::FormattedStringWithEquivalentMeaning(url,
                                                                 display_string);
+    match.allowed_to_be_default_match = true;
     // NOTE: Don't set match.inline_autocompletion to something non-empty here;
     // it's surprising and annoying.
 
@@ -1065,6 +1066,9 @@ AutocompleteMatch HistoryURLProvider::HistoryMatchToACMatch(
     match.inline_autocompletion =
         match.fill_into_edit.substr(inline_autocomplete_offset);
   }
+  match.allowed_to_be_default_match = !params->prevent_inline_autocomplete ||

[msw, 2013/08/07 20:09:21]

Shouldn't this match never be default if prevent inline autocomplete is true?
It looks like this allows default inline autocomplete when prevent is true.
But I might be reading this wrong...

[Mark P, 2013/08/07 22:13:05]

The latter part of the test effectively says "is there any inline completion". 
If no, then the match is allowed.  Added comment.

I thought writing the test this way would be better than putting something in
the if statement above and then having an else to handle other cases.  (i.e.,
put the allowed_to_be_default_match setting code all in one place)

+      ((inline_autocomplete_offset != string16::npos) &&
+       (inline_autocomplete_offset >= match.fill_into_edit.length()));
 
   size_t match_start = history_match.input_location;
   match.contents = net::FormatUrl(info.url(), languages,