Omnibox: Make the Controller Reorder Matches for Inlining

chrome/browser/autocomplete/shortcuts_provider_unittest.cc

Index: chrome/browser/autocomplete/shortcuts_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
index 73699dbd4dbe80fbd2c66957357a15440a913643..9ad05e4118e35c14288c11d68fbd4a5c702ce35b 100644
--- a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
@@ -254,6 +254,12 @@ void ShortcutsProviderTest::RunTest(const string16 text,
                       ac_matches_.end(), AutocompleteMatch::MoreRelevant);
     EXPECT_EQ(expected_top_result, ac_matches_[0].destination_url.spec());
   }
+
+  // No shortcuts matches are allowed to be inlined no matter how highly
+  // they score.

[Peter Kasting, 2013/08/06 22:56:16]

Nit: Should this have a TODO to change this to allow ShortcutsProvider to
inline?

[Mark P, 2013/08/07 00:44:31]

No.  TODOs in code should be trivial.  I'm not even sure we want to allow them
to ever inline; this can cause a positive feedback loop that might be hard to
overcome depending on the details of the scoring algorithm.  We should create a
bug if you want to discuss it; it any case the issue is bigger than a TODO
within the code.

+  for (ACMatches::const_iterator it = ac_matches_.begin();
+       it != ac_matches_.end(); ++it)
+    EXPECT_FALSE(it->allowed_to_be_default_match);
 }
 
 TEST_F(ShortcutsProviderTest, SimpleSingleMatch) {