Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_match.h

Issue 18878007: Omnibox: Make the Controller Reorder Matches for Inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one final pass through the code Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 // This string is loaded into the location bar when the item is selected 244 // This string is loaded into the location bar when the item is selected
245 // by pressing the arrow keys. This may be different than a URL, for example, 245 // by pressing the arrow keys. This may be different than a URL, for example,
246 // for search suggestions, this would just be the search terms. 246 // for search suggestions, this would just be the search terms.
247 string16 fill_into_edit; 247 string16 fill_into_edit;
248 248
249 // The position within fill_into_edit from which we'll display the inline 249 // The position within fill_into_edit from which we'll display the inline
250 // autocomplete string. This will be string16::npos if this match should 250 // autocomplete string. This will be string16::npos if this match should
251 // not be inline autocompleted. 251 // not be inline autocompleted.
252 size_t inline_autocomplete_offset; 252 size_t inline_autocomplete_offset;
253 253
254 // If false, the omnibox should prevent this match from being the default
255 // match.
Peter Kasting 2013/07/17 18:29:48 Nit: I might add something like: Providers should
Mark P 2013/07/17 20:39:18 That's a good explanation. Inserted with minor ed
256 bool allowed_to_be_default_match;
257
254 // The URL to actually load when the autocomplete item is selected. This URL 258 // The URL to actually load when the autocomplete item is selected. This URL
255 // should be canonical so we can compare URLs with strcmp to avoid dupes. 259 // should be canonical so we can compare URLs with strcmp to avoid dupes.
256 // It may be empty if there is no possible navigation. 260 // It may be empty if there is no possible navigation.
257 GURL destination_url; 261 GURL destination_url;
258 262
259 // The destination URL with "www." stripped off for better dupe finding. 263 // The destination URL with "www." stripped off for better dupe finding.
260 GURL stripped_destination_url; 264 GURL stripped_destination_url;
261 265
262 // The main text displayed in the address bar dropdown. 266 // The main text displayed in the address bar dropdown.
263 string16 contents; 267 string16 contents;
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 const string16& text, 329 const string16& text,
326 const ACMatchClassifications& classifications) const; 330 const ACMatchClassifications& classifications) const;
327 #endif 331 #endif
328 }; 332 };
329 333
330 typedef AutocompleteMatch::ACMatchClassification ACMatchClassification; 334 typedef AutocompleteMatch::ACMatchClassification ACMatchClassification;
331 typedef std::vector<ACMatchClassification> ACMatchClassifications; 335 typedef std::vector<ACMatchClassification> ACMatchClassifications;
332 typedef std::vector<AutocompleteMatch> ACMatches; 336 typedef std::vector<AutocompleteMatch> ACMatches;
333 337
334 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_ 338 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_MATCH_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_match.cc » ('j') | chrome/browser/autocomplete/autocomplete_result.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698