Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/omnibox/omnibox_field_trial.cc

Issue 18878007: Omnibox: Make the Controller Reorder Matches for Inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/omnibox/omnibox_field_trial.h" 5 #include "chrome/browser/omnibox/omnibox_field_trial.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "chrome/common/metrics/metrics_util.h" 13 #include "chrome/common/metrics/metrics_util.h"
14 #include "chrome/common/metrics/variations/variation_ids.h" 14 #include "chrome/common/metrics/variations/variation_ids.h"
15 #include "chrome/common/metrics/variations/variations_util.h" 15 #include "chrome/common/metrics/variations/variations_util.h"
16 16
17 namespace { 17 namespace {
18 18
19 // Field trial names. 19 // Field trial names.
20 const char kDisallowInlineHQPFieldTrialName[] = "OmniboxDisallowInlineHQP"; 20 const char kDisallowInlineHQPFieldTrialName[] = "OmniboxDisallowInlineHQP";
21 const char kHUPCullRedirectsFieldTrialName[] = "OmniboxHUPCullRedirects"; 21 const char kHUPCullRedirectsFieldTrialName[] = "OmniboxHUPCullRedirects";
22 const char kHUPCreateShorterMatchFieldTrialName[] = 22 const char kHUPCreateShorterMatchFieldTrialName[] =
23 "OmniboxHUPCreateShorterMatch"; 23 "OmniboxHUPCreateShorterMatch";
24 const char kStopTimerFieldTrialName[] = "OmniboxStopTimer"; 24 const char kStopTimerFieldTrialName[] = "OmniboxStopTimer";
25 const char kShortcutsScoringFieldTrialName[] = "OmniboxShortcutsScoring"; 25 const char kShortcutsScoringFieldTrialName[] = "OmniboxShortcutsScoring";
26 const char kSearchHistoryFieldTrialName[] = "OmniboxSearchHistory"; 26 const char kSearchHistoryFieldTrialName[] = "OmniboxSearchHistory";
27 const char kReorderForInliningFieldTrialName[] = "OmniboxReorderForInlining";
27 28
28 // The autocomplete dynamic field trial name prefix. Each field trial is 29 // The autocomplete dynamic field trial name prefix. Each field trial is
29 // configured dynamically and is retrieved automatically by Chrome during 30 // configured dynamically and is retrieved automatically by Chrome during
30 // the startup. 31 // the startup.
31 const char kAutocompleteDynamicFieldTrialPrefix[] = "AutocompleteDynamicTrial_"; 32 const char kAutocompleteDynamicFieldTrialPrefix[] = "AutocompleteDynamicTrial_";
32 // The maximum number of the autocomplete dynamic field trials (aka layers). 33 // The maximum number of the autocomplete dynamic field trials (aka layers).
33 const int kMaxAutocompleteDynamicFieldTrials = 5; 34 const int kMaxAutocompleteDynamicFieldTrials = 5;
34 35
35 // Field trial experiment probabilities. 36 // Field trial experiment probabilities.
36 37
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 263
263 bool OmniboxFieldTrial::SearchHistoryPreventInlining() { 264 bool OmniboxFieldTrial::SearchHistoryPreventInlining() {
264 return (base::FieldTrialList::FindFullName(kSearchHistoryFieldTrialName) == 265 return (base::FieldTrialList::FindFullName(kSearchHistoryFieldTrialName) ==
265 "PreventInlining"); 266 "PreventInlining");
266 } 267 }
267 268
268 bool OmniboxFieldTrial::SearchHistoryDisable() { 269 bool OmniboxFieldTrial::SearchHistoryDisable() {
269 return (base::FieldTrialList::FindFullName(kSearchHistoryFieldTrialName) == 270 return (base::FieldTrialList::FindFullName(kSearchHistoryFieldTrialName) ==
270 "Disable"); 271 "Disable");
271 } 272 }
273
274 bool OmniboxFieldTrial::InReorderForInliningGroup() {
275 return (base::FieldTrialList::FindFullName(
276 kReorderForInliningFieldTrialName) == "ReorderForInlining");
Peter Kasting 2013/07/13 01:31:40 Nit: Indent 4, not 12
Mark P 2013/07/17 15:45:18 Done.
277 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698