Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: chrome/browser/autocomplete/history_quick_provider.h

Issue 18878007: Omnibox: Make the Controller Reorder Matches for Inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // gets demoted to a lower score (1198) because we try to preserve 88 // gets demoted to a lower score (1198) because we try to preserve
89 // the order. On the other hand, if reorder_for_inlining_ is true, 89 // the order. On the other hand, if reorder_for_inlining_ is true,
90 // then y keeps its score of 2500 and x gets demoted to 2499 in 90 // then y keeps its score of 2500 and x gets demoted to 2499 in
91 // order to follow y. There will not be any problems with an 91 // order to follow y. There will not be any problems with an
92 // unexpected inline because the non-inlineable result x scores 92 // unexpected inline because the non-inlineable result x scores
93 // lower than the inlineable one. 93 // lower than the inlineable one.
94 // TODO(mpearson): remove this variable after we're done experimenting. 94 // TODO(mpearson): remove this variable after we're done experimenting.
95 // (This member is meant to only exist for experimentation purposes. 95 // (This member is meant to only exist for experimentation purposes.
96 // Once we know which behavior is better, we should rip out this variable 96 // Once we know which behavior is better, we should rip out this variable
97 // and make the best behavior the default.) 97 // and make the best behavior the default.)
98 bool reorder_for_inlining_; 98 bool local_reorder_for_inlining_;
99
100 // True if the omnibox will reorder matches as necessary to make the top
101 // result inlineable.
102 bool omnibox_will_reorder_for_inlining_;
99 103
100 // Only used for testing. 104 // Only used for testing.
101 scoped_ptr<history::InMemoryURLIndex> index_for_testing_; 105 scoped_ptr<history::InMemoryURLIndex> index_for_testing_;
102 106
103 // This provider is disabled when true. 107 // This provider is disabled when true.
104 static bool disabled_; 108 static bool disabled_;
105 109
106 DISALLOW_COPY_AND_ASSIGN(HistoryQuickProvider); 110 DISALLOW_COPY_AND_ASSIGN(HistoryQuickProvider);
107 }; 111 };
108 112
109 #endif // CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_ 113 #endif // CHROME_BROWSER_AUTOCOMPLETE_HISTORY_QUICK_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698