Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1887783002: Remove Extensions.EnhancedBookmarksManagerNumEventListeners metric (Closed)

Created:
4 years, 8 months ago by Mike Wittman
Modified:
4 years, 8 months ago
Reviewers:
Devlin, jwd
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org, Rune Fevang
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Extensions.EnhancedBookmarksManagerNumEventListeners metric This is obsolete since the enhanced bookmarks manager is no longer using an event page. BUG=603149 Committed: https://crrev.com/3e9039124071c256c797a0b84ca150b89989f5fe Cr-Commit-Position: refs/heads/master@{#387802}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M chrome/browser/extensions/installed_loader.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
Mike Wittman
4 years, 8 months ago (2016-04-13 20:24:08 UTC) #2
Devlin
lgtm
4 years, 8 months ago (2016-04-13 22:51:50 UTC) #3
jwd
LGTM with small change. https://codereview.chromium.org/1887783002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1887783002/diff/1/tools/metrics/histograms/histograms.xml#newcode13167 tools/metrics/histograms/histograms.xml:13167: + page. Can you add ...
4 years, 8 months ago (2016-04-15 14:55:26 UTC) #4
Mike Wittman
https://codereview.chromium.org/1887783002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1887783002/diff/1/tools/metrics/histograms/histograms.xml#newcode13167 tools/metrics/histograms/histograms.xml:13167: + page. On 2016/04/15 14:55:26, Jesse Doherty wrote: > ...
4 years, 8 months ago (2016-04-15 15:06:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887783002/1
4 years, 8 months ago (2016-04-16 00:40:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 02:48:09 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 02:50:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e9039124071c256c797a0b84ca150b89989f5fe
Cr-Commit-Position: refs/heads/master@{#387802}

Powered by Google App Engine
This is Rietveld 408576698