Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1887743002: Re-scope inner scopes in arrow parameter initializers (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 8 months ago
Reviewers:
rossberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-scope inner scopes in arrow parameter initializers This patch correctly re-scopes inner scopes that can appear in do expressions used as initializers to arrow parameters. R=rossberg@chromium.org BUG=v8:4904 LOG=N Committed: https://crrev.com/451fa77235e39a494b1abc3bb21a696373397e7e Cr-Commit-Position: refs/heads/master@{#35542}

Patch Set 1 #

Patch Set 2 : Rebase and mark mjsunit/harmony/regress/regress-4658 as good for ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M src/ast/ast-expression-visitor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parameter-initializer-rewriter.cc View 2 chunks +24 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/regress/regress-4904.js View 1 chunk +24 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nickie
4 years, 8 months ago (2016-04-13 18:01:37 UTC) #1
rossberg
lgtm
4 years, 8 months ago (2016-04-13 18:28:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887743002/1
4 years, 8 months ago (2016-04-15 14:08:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/230) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-15 14:29:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887743002/20001
4 years, 8 months ago (2016-04-15 14:57:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 18:08:04 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/451fa77235e39a494b1abc3bb21a696373397e7e Cr-Commit-Position: refs/heads/master@{#35542}
4 years, 8 months ago (2016-04-15 18:08:43 UTC) #14
adamk
4 years, 8 months ago (2016-04-18 17:25:14 UTC) #16
Message was sent while issue was closed.
Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698