Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
188773002:
Clean up static_cast<CSSFooValue*> in CSSValue.cpp (Closed)
|
Created:
6 years, 9 months ago by gyuyoung-inactive Modified:
6 years, 9 months ago CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionClean up static_cast<CSSFooValue*> in CSSValue.cpp
This cl removes remained static_cast<CSSFooValue*> usage in CSSValue.cpp.
BUG=309516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169038
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Rebased #2 #Patch Set 4 : Rebased #3 #Patch Set 5 : Rebased #5 #Messages
Total messages: 26 (0 generated)
Add tkent.
LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile
The CQ bit was checked by gyuyoung.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel
The CQ bit was checked by gyuyoung.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink
It looks this patch doesn't influence on layout test. I don't know why this is not landed. Let me try one more time.
The CQ bit was checked by gyuyoung.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink
The CQ bit was checked by gyuyoung.kim@samsung.com
On 2014/03/09 06:23:01, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: linux_blink When I run below failing tests locally, there was no fail. Looks flaky tests. Try again. webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html svg/animations/svglengthlist-animation-3.html
The CQ bit was unchecked by gyuyoung.kim@samsung.com
The CQ bit was checked by gyuyoung.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/80001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/188773002/80001
Message was sent while issue was closed.
Change committed as 169038 |
