Fix header map nextPowerOf2 method.

Fix header map nextPowerOf2 method.

Ensure that capacity is always the next power of two over count. This
fixes a bug where capacity and count could be equal if count was
already a power of two.

BUG=603210
R=sdefresne@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/db72e9fcf55ba9d8089f0bc7e447180f8972b5c0

[justincohen, 2016-04-14 14:15:59]

Description was changed from

==========
Make sure there's always one buffer bucket for header maps.

BUG=
==========

to

==========
Fix header map nextPowerOf2 method.

Ensure that capacity is always the next power of two over count. This
fixes a bug where capacity and count could be equal if count was
already a power of two.

BUG=603210
==========

[justincohen, 2016-04-14 14:16:33]

justincohen@chromium.org changed reviewers:
+ nicholss@chromium.org, sdefresne@chromium.org

[justincohen, 2016-04-14 14:16:34]

Scott, can you re-patch in this CL to confirm it still works for you.  This is
slightly different fix.

[sdefresne, 2016-04-14 14:19:48]

On 2016/04/14 at 14:16:34, justincohen wrote:
> Scott, can you re-patch in this CL to confirm it still works for you.  This is
slightly different fix.

Can you write simple unit test for the function?

[Justin Cohen (wrong one), 2016-04-14 15:47:52]

justincohen@google.com changed reviewers:
+ justincohen@google.com

[Justin Cohen (wrong one), 2016-04-14 15:47:53]

Added second file to test so the compiled framework has a power of 2 number of
header files (2).  PTAL

[nicholss, 2016-04-14 16:42:44]

I confirm that this change also fixed my build issue for a framework that pulls
in base header files.

[sdefresne, 2016-04-14 21:31:13]

lgtm

https://codereview.chromium.org/1887703004/diff/40001/test/ios/framework/fram...
File test/ios/framework/framework.gyp (right):

https://codereview.chromium.org/1887703004/diff/40001/test/ios/framework/fram...
test/ios/framework/framework.gyp:12: 'iOSFramework/iOSFramework.h',
Can you add a comment here saying that you are using two headers (or a power of
two) to exercise NextGreaterPowerOf2?

[Justin Cohen (wrong one), 2016-04-18 14:18:46]

https://codereview.chromium.org/1887703004/diff/40001/test/ios/framework/fram...
File test/ios/framework/framework.gyp (right):

https://codereview.chromium.org/1887703004/diff/40001/test/ios/framework/fram...
test/ios/framework/framework.gyp:12: 'iOSFramework/iOSFramework.h',
On 2016/04/14 21:31:13, sdefresne wrote:
> Can you add a comment here saying that you are using two headers (or a power
of
> two) to exercise NextGreaterPowerOf2?

Done.

[justincohen, 2016-04-18 14:36:57]

Description was changed from

==========
Fix header map nextPowerOf2 method.

Ensure that capacity is always the next power of two over count. This
fixes a bug where capacity and count could be equal if count was
already a power of two.

BUG=603210
==========

to

==========
Fix header map nextPowerOf2 method.

Ensure that capacity is always the next power of two over count. This
fixes a bug where capacity and count could be equal if count was
already a power of two.

BUG=603210
R=sdefresne@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/db72e9fcf55ba9d8089f0bc7e447...
==========

[justincohen, 2016-04-18 14:36:58]

Committed patchset #4 (id:60001) manually as
db72e9fcf55ba9d8089f0bc7e447180f8972b5c0 (presubmit successful).