Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1887703002:
cc: Add a main thread LayerListIterator (Closed)
Descriptioncc: Add a main thread LayerListIterator
Make LayerListIterator a template class for Layer and LayerImpl.
Add tests for LayerListIterator<Layer>.
Noted that cc_unittests:
LayerTreeHostCopyRequestTestLostOutputSurface.
RunMultiThread_DirectRenderer might be flacky.
BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8
Cr-Commit-Position: refs/heads/master@{#387422}
Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2
Cr-Commit-Position: refs/heads/master@{#387908}
Committed: https://crrev.com/f354ca2b2497a54b41591a7856fa0dde445d7beb
Cr-Commit-Position: refs/heads/master@{#387957}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Unify Layer/LayerImpl iterator tests #Patch Set 3 : Revert patch2 #Patch Set 4 : Reopen to try to reproduce the bug #Patch Set 5 : TEMPORARY: Add LOG(ERROR) to find out the timeout reason #Patch Set 6 : For testing only #
Messages
Total messages: 40 (21 generated)
Description was changed from ========== Make LayerListIterator a template class for Layer and LayerImpl BUG=603181 ========== to ========== Make LayerListIterator a template class for Layer and LayerImpl BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Make LayerListIterator a template class for Layer and LayerImpl BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
sunxd@chromium.org changed reviewers: + ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org
https://codereview.chromium.org/1887703002/diff/1/cc/layers/layer_list_iterat... File cc/layers/layer_list_iterator_unittest.cc (right): https://codereview.chromium.org/1887703002/diff/1/cc/layers/layer_list_iterat... cc/layers/layer_list_iterator_unittest.cc:195: // LayerImpl version unit tests Please use a macro to stamp out a Layer and LayerImpl version of the unittest.
On 2016/04/14 19:01:36, sunxd wrote: Thanks for trying to unify the code, but given how many differences there are between the Layer and LayerImpl versions of the test, the resulting solution is probably more complicated than it's worth. The previous patchset lgtm.
The CQ bit was checked by sunxd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org Link to the patchset: https://codereview.chromium.org/1887703002/#ps40001 (title: "Revert patch2")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887703002/40001
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1888453006/ by rjkroege@chromium.org. The reason for reverting is: Per: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2..., I think that this CL breaks cc unit tests. [ RUN ] LayerTreeHostCopyRequestTestLostOutputSurface.RunMultiThread_DirectRenderer c:\b\build\slave\win_builder__dbg_\build\src\cc\test\layer_tree_test.cc(899): error: Failed Test timed out [ FAILED ] LayerTreeHostCopyRequestTestLostOutputSurface.RunMultiThread_DirectRenderer (5006 ms) .
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ==========
The CQ bit was checked by sunxd@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887703002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887703002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ==========
The CQ bit was checked by sunxd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org Link to the patchset: https://codereview.chromium.org/1887703002/#ps100001 (title: "For testing only")
The CQ bit was unchecked by sunxd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887703002/100001
The CQ bit was checked by sunxd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887703002/100001
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1900723002/ by sunxd@chromium.org. The reason for reverting is: Possible failure to android_clang_buildbot (https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Clan...).
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ==========
The CQ bit was checked by sunxd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887703002/100001
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} ========== to ========== cc: Add a main thread LayerListIterator Make LayerListIterator a template class for Layer and LayerImpl. Add tests for LayerListIterator<Layer>. Noted that cc_unittests: LayerTreeHostCopyRequestTestLostOutputSurface. RunMultiThread_DirectRenderer might be flacky. BUG=603181 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7a1807b49236a338953fea5e7f7f6f6f9cbb0aa8 Cr-Commit-Position: refs/heads/master@{#387422} Committed: https://crrev.com/0e1785c782ce5d569d21beb8770e7a204a2729a2 Cr-Commit-Position: refs/heads/master@{#387908} Committed: https://crrev.com/f354ca2b2497a54b41591a7856fa0dde445d7beb Cr-Commit-Position: refs/heads/master@{#387957} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f354ca2b2497a54b41591a7856fa0dde445d7beb Cr-Commit-Position: refs/heads/master@{#387957} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
