Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1887673002: [compiler] Drop obsolete compiler hint setting. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Drop obsolete compiler hint setting. The compiler hints in question are already correctly initialized by the NewSharedFunctionInfoForLiteral function. Reinitializing them again here is no longer needed by now. R=bmeurer@chromium.org Committed: https://crrev.com/793ae860e57fb02d841564852c9098e50d339b7d Cr-Commit-Position: refs/heads/master@{#35471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-13 16:05:18 UTC) #3
Benedikt Meurer
Nice. LGTM.
4 years, 8 months ago (2016-04-14 04:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887673002/1
4 years, 8 months ago (2016-04-14 07:58:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:00:37 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:01:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/793ae860e57fb02d841564852c9098e50d339b7d
Cr-Commit-Position: refs/heads/master@{#35471}

Powered by Google App Engine
This is Rietveld 408576698