Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887643002: clang/win: Stop passing -Qunused-arguments in pdfium too. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com, Oliver Chang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

clang/win: Stop passing -Qunused-arguments in pdfium too. We stopped passing this in Chromium a while ago. BUG=504658 Committed: https://pdfium.googlesource.com/pdfium/+/112be9813ed7bf4e082048eda5f4a7d3837d116c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/standalone.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
4 years, 8 months ago (2016-04-13 12:35:35 UTC) #2
dsinclair
lgtm
4 years, 8 months ago (2016-04-13 12:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887643002/1
4 years, 8 months ago (2016-04-13 12:57:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/112be9813ed7bf4e082048eda5f4a7d3837d116c
4 years, 8 months ago (2016-04-13 13:04:08 UTC) #8
Nico
4 years, 8 months ago (2016-04-13 13:19:30 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1883823002/ by thakis@chromium.org.

The reason for reverting is: pdfium still passes /GS.

Powered by Google App Engine
This is Rietveld 408576698