chrome/browser/push_messaging/push_messaging_notification_manager.h - Issue 1887623002: Replace the 1 in 10 grace period with an accumulating budget based on SES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.h

Issue 1887623002: Replace the 1 in 10 grace period with an accumulating budget based on SES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/push_messaging/background_budget_service_unittest.cc ('K') | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/browser/push_messaging/push_messaging_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager.h

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.h b/chrome/browser/push_messaging/push_messaging_notification_manager.h

index c15eb21a6e7b864c4f2c6e5ea761d356ae490f48..736d91b654bb44694a89ebfc56a5f7e14a9c98ff 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager.h

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.h

@@ -75,10 +75,8 @@ class PushMessagingNotificationManager {

void DidGetBudget(const GURL& origin,

int64_t service_worker_registration_id,

- bool notification_shown,

- bool notification_needed,

const base::Closure& message_handled_closure,

- const std::string& data);

+ const double budget);

Peter Beverloo 2016/04/14 18:02:09 nit: we don't usually put "const" in front of scal

harkness 2016/04/27 11:21:09 Done.

static void DidWriteNotificationDataIOProxy(

const base::WeakPtr<PushMessagingNotificationManager>& ui_weak_ptr,