Replace the 1 in 10 grace period with an accumulating budget based on SES.

chrome/browser/push_messaging/background_budget_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <string>
 
+#include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/browser/push_messaging/background_budget_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kTestOrigin[] = "https://example.com";
-const char kTestData[] = "1111101111";
+const double kTestBudget = 10.0;
+const double kTestSES = 24.0;
 
 }  // namespace
 
 class BackgroundBudgetServiceTest : public testing::Test {
  public:
   BackgroundBudgetServiceTest() {}
   ~BackgroundBudgetServiceTest() override {}
 
   TestingProfile* profile() { return &profile_; }
 
+  void SetSiteEngagementScore(const GURL& url, double score) {
+    SiteEngagementService* service = SiteEngagementService::Get(&profile_);
+    service->ResetScoreForURL(url, score);
+  }
+
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
 };
 
-TEST_F(BackgroundBudgetServiceTest, GetBudgetFailure) {
+TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetOrSES) {
   const GURL origin(kTestOrigin);
 
-  std::string budget_string =
-      BackgroundBudgetService::GetBudget(profile(), origin);
+  double budget = 0.0;
+  BackgroundBudgetService::GetBudget(profile(), origin, budget);
 
-  EXPECT_EQ(std::string(), budget_string);
+  EXPECT_EQ(budget, 0.0);

[Peter Beverloo, 2016/04/14 18:02:09]

EXPECT_DOUBLE_EQ(), elsewhere too

Comparisons are evil for doubles.

[harkness, 2016/04/27 11:21:08]

Done, and I changed a lot of them to EXPECT_NEAR with appropriate bounds.

 }
 
-TEST_F(BackgroundBudgetServiceTest, GetBudgetSuccess) {
+TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetSESExists) {
   const GURL origin(kTestOrigin);
 
-  BackgroundBudgetService::StoreBudget(profile(), origin, kTestData);
+  // Set a starting SES for the url but no stored budget info.
+  SetSiteEngagementScore(origin, kTestSES);
 
-  std::string budget_string =
-      BackgroundBudgetService::GetBudget(profile(), origin);
+  double budget = 0.0;
+  BackgroundBudgetService::GetBudget(profile(), origin, budget);
 
-  EXPECT_EQ(kTestData, budget_string);
+  EXPECT_EQ(budget, kTestSES);
 }
+
+TEST_F(BackgroundBudgetServiceTest, GetBudgetNoElapsedTime) {
+  const GURL origin(kTestOrigin);
+
+  BackgroundBudgetService::StoreBudget(profile(), origin, kTestBudget);
+
+  double budget = 0.0;
+  BackgroundBudgetService::GetBudget(profile(), origin, budget);
+
+  EXPECT_EQ(budget, kTestBudget);

[Peter Beverloo, 2016/04/14 18:02:09]

You probably want to talk to Sami about a thing we have called "virtual time". I
don't know how usable it will be for your case, or if it has been implemented at
all, but as I understand it, it would be a fantastic way to power your unit
tests.

I do feel we need more coverage for the calculations you're introducing. An easy
option could be to store "historic" values in the preferences manually, getting
the budget and seeing what happens.

[harkness, 2016/04/27 11:21:08]

Many more tests added, now that I have a clock in the BackgroundBudgetService. 

+}