Issue 1887613002: Compare font-feature-settings as part of Font::operator==().

Issue 1887613002: Compare font-feature-settings as part of Font::operator==(). (Closed)

Created:
4 years, 8 months ago by rune

Modified:
4 years, 8 months ago

Reviewers:
eae

CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Compare font-feature-settings as part of Font::operator==(). We only did a pointer comparison which always failed when doing a style recalc since a style recalc always creates a new FontFeatureSetting object. R=eae@chromium.org BUG=602802, 602959 Committed: https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a Cr-Commit-Position: refs/heads/master@{#387001}

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -3 lines)			Patch
A	third_party/WebKit/LayoutTests/fast/css/font-feature-settings-assert.html	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/css/font-feature-settings-assert-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/css/invalidation/font-feature-settings.html	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/css/invalidation/font-feature-settings-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/FontDescription.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/FontFeatureSettings.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/FontFeatureSettings.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 11 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887613002/1

4 years, 8 months ago (2016-04-13 10:01:55 UTC) #2

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 8 months ago (2016-04-13 11:10:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887613002/1

4 years, 8 months ago (2016-04-13 15:52:56 UTC) #8

commit-bot: I haz the power

4 years, 8 months ago (2016-04-13 16:00:14 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a
Cr-Commit-Position: refs/heads/master@{#387001}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages