Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 1887583002: [release] Let release script fix missing tags. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release] Let release script fix missing tags. Check if a previous run left an inconsistent state behind. The check is right before trying to push a new state as then all information is available, like commit message and tag name. This is still only a band-aid. If gnumbd is down for a longer period, an unprocessed commit won't be found, but the push attempt will still fail. Committed: https://crrev.com/6fe3387778cc1829f89c90bf11a9532fb42fb578 Cr-Commit-Position: refs/heads/master@{#35437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M tools/release/create_release.py View 2 chunks +22 lines, -0 lines 0 comments Download
M tools/release/test_scripts.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL. Didn't add a test for that case as it'd be quite huge.
4 years, 8 months ago (2016-04-13 08:15:39 UTC) #3
Michael Hablich
On 2016/04/13 08:15:39, Michael Achenbach wrote: > PTAL. Didn't add a test for that case ...
4 years, 8 months ago (2016-04-13 09:37:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887583002/1
4 years, 8 months ago (2016-04-13 09:37:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 10:00:00 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 10:01:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fe3387778cc1829f89c90bf11a9532fb42fb578
Cr-Commit-Position: refs/heads/master@{#35437}

Powered by Google App Engine
This is Rietveld 408576698