Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887573002: Remove ENABLE(OILPAN) from ScriptRunner and PendingScript. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ENABLE(OILPAN) from ScriptRunner and PendingScript. R=haraken BUG=585328 Committed: https://crrev.com/e6c694071ae90e62dd2ee852b030da4e8b47ec5d Cr-Commit-Position: refs/heads/master@{#386938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -56 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 4 chunks +2 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. I've been looking forward to this removal :)
4 years, 8 months ago (2016-04-13 06:50:17 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-13 06:54:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887573002/1
4 years, 8 months ago (2016-04-13 07:05:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 08:30:15 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 08:31:45 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6c694071ae90e62dd2ee852b030da4e8b47ec5d
Cr-Commit-Position: refs/heads/master@{#386938}

Powered by Google App Engine
This is Rietveld 408576698