ozone: fix crash when running video decode unittests.

ozone: fix crash when running video decode unittests.

In GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy, if the previous
context was NULL, do not make it current.

BUG=chromium:602921
TEST=Run vda unittests on oak.

Committed: https://crrev.com/2f663de43634c1197a7a2ed8afc12cb6dc565bd0
Cr-Commit-Position: refs/heads/master@{#386988}

[wuchengli, 2016-04-13 06:03:18]

wuchengli@chromium.org changed reviewers:
+ dnicoara@chromium.org, spang@chromium.org

[wuchengli, 2016-04-13 06:03:18]

PTAL.

[spang, 2016-04-13 14:00:49]

https://codereview.chromium.org/1887563002/diff/1/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/1887563002/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:606: if (previous_context) {
Seems like it should be

if (!was_current && previous_context) {
  previous_context->MakeCurrent(previous_surface.get());
} else {
  context_->ReleaseCurrent(this);
}

[spang, 2016-04-13 14:16:21]

lgtm

https://codereview.chromium.org/1887563002/diff/1/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/1887563002/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:606: if (previous_context) {
On 2016/04/13 14:00:49, spang wrote:
> Seems like it should be
> 
> if (!was_current && previous_context) {
>   previous_context->MakeCurrent(previous_surface.get());
> } else {
>   context_->ReleaseCurrent(this);
> }

I guess it's fine the way it is, if you fall through here with the surface left
current it'll clear it it in GLSurface::~GLSurface.

[wuchengli, 2016-04-13 14:20:58]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2016-04-13 14:21:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887563002/1

[commit-bot: I haz the power, 2016-04-13 14:57:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 14:58:25]

Description was changed from

==========
ozone: fix crash when running video decode unittests.

In GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy, if the previous
context was NULL, do not make it current.

BUG=chromium:602921
TEST=Run vda unittests on oak.
==========

to

==========
ozone: fix crash when running video decode unittests.

In GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy, if the previous
context was NULL, do not make it current.

BUG=chromium:602921
TEST=Run vda unittests on oak.

Committed: https://crrev.com/2f663de43634c1197a7a2ed8afc12cb6dc565bd0
Cr-Commit-Position: refs/heads/master@{#386988}
==========

[commit-bot: I haz the power, 2016-04-13 14:58:26]

Patchset 1 (id:??) landed as
https://crrev.com/2f663de43634c1197a7a2ed8afc12cb6dc565bd0
Cr-Commit-Position: refs/heads/master@{#386988}