third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp - Issue 1887553002: Make sure binding security checks don't pass if the frame is remote.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

Issue 1887553002: Make sure binding security checks don't pass if the frame is remote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager_browsertest.cc ('K') | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

index 186f6a165a308c8b33d6afa9eb905d74b7421c16..aac8023e72a0531bcf7bb8caaa774a127c09fbf2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

@@ -50,7 +50,7 @@ static bool canAccessFrame(v8::Isolate* isolate, const LocalDOMWindow* accessing

{

ASSERT_WITH_SECURITY_IMPLICATION(!(targetWindow && targetWindow->frame()) || targetWindow == targetWindow->frame()->domWindow());

- if (isOriginAccessibleFromDOMWindow(targetFrameOrigin, accessingWindow))

haraken 2016/04/13 04:43:19 isOriginAccessibleFromDOMWindow has already been h

+ if (targetWindow->isLocalDOMWindow() && isOriginAccessibleFromDOMWindow(targetFrameOrigin, accessingWindow))

return true;

if (targetWindow)

@@ -62,7 +62,7 @@ static bool canAccessFrame(v8::Isolate* isolate, const LocalDOMWindow* accessing

{

ASSERT_WITH_SECURITY_IMPLICATION(!(targetWindow && targetWindow->frame()) || targetWindow == targetWindow->frame()->domWindow());

- if (isOriginAccessibleFromDOMWindow(targetFrameOrigin, accessingWindow))

+ if (targetWindow->isLocalDOMWindow() && isOriginAccessibleFromDOMWindow(targetFrameOrigin, accessingWindow))

return true;

if (reportingOption == ReportSecurityError && targetWindow)