Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1887493004: [Interpreter] No longer require context machine register in bytecode handlers (Closed)

Created:
4 years, 8 months ago by rmcilroy
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_dispatch
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] No longer require context machine register in bytecode handlers The current context is stored as a stack slot on the interpreter frame and therefore we don't need to also maintain a machine register for the context. Removes this register from bytecode handlers. In the process modifies this frees up a register on ia32 to keep the dispatch table pointer in a register rather than on a stack slot on ia32. BUG=v8:4280 LOG=N Committed: https://crrev.com/6dca3193959f912d6b87dbac5004a366dd35e3c3 Cr-Commit-Position: refs/heads/master@{#35511}

Patch Set 1 #

Patch Set 2 : Fix x87 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -125 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +13 lines, -28 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 3 chunks +13 lines, -28 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887493004/1
4 years, 8 months ago (2016-04-13 12:19:58 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4194)
4 years, 8 months ago (2016-04-13 12:22:49 UTC) #4
rmcilroy
Benedikt, PTAL. This is a follow on from https://codereview.chromium.org/1882073002/.
4 years, 8 months ago (2016-04-13 12:57:24 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887493004/20001
4 years, 8 months ago (2016-04-13 12:59:01 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 13:51:24 UTC) #10
Benedikt Meurer
Sorry this somehow slipped thru the cracks, feel free to just send me the review ...
4 years, 8 months ago (2016-04-14 18:42:27 UTC) #11
rmcilroy
On 2016/04/14 18:42:27, Benedikt Meurer wrote: > Sorry this somehow slipped thru the cracks, feel ...
4 years, 8 months ago (2016-04-15 09:09:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887493004/20001
4 years, 8 months ago (2016-04-15 09:09:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 09:33:31 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 09:34:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dca3193959f912d6b87dbac5004a366dd35e3c3
Cr-Commit-Position: refs/heads/master@{#35511}

Powered by Google App Engine
This is Rietveld 408576698