Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1887463002: Remove all usage of WebGraphicsContext3D in blink unit tests. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis, chrishtr, dcheng, Ken Russell (switch to Gerrit), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all usage of WebGraphicsContext3D in blink unit tests. And rename/remove code around "Mocks" that we are not actually using as mocks. Instead name these as "Fake" as they provide some behaviour overrides for tests. R=bajones@chromium.org, kbr@chromium.org, pdr@chromium.org, zmo@chromium.org BUG=584497 Committed: https://crrev.com/c01aab9fd28f2f9e6856dca6c243470c39305cd9 Cr-Commit-Position: refs/heads/master@{#387129}

Patch Set 1 #

Patch Set 2 : nowgc3d-tests: removemockwebgc3d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -367 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 32 chunks +98 lines, -186 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 20 chunks +50 lines, -111 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/test/FakeGLES2Interface.h View 1 chunk +6 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/MockGLES2Interface.h View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/test/MockWebGraphicsContext3D.h View 1 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
danakj
bajones/zmo: please review! pdr: OWNERS plz
4 years, 8 months ago (2016-04-12 22:11:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887463002/1
4 years, 8 months ago (2016-04-12 22:12:17 UTC) #3
danakj
Oh, I also renamed things from "Mock" that we were not using as Mocks, and ...
4 years, 8 months ago (2016-04-12 22:12:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887463002/20001
4 years, 8 months ago (2016-04-12 23:20:31 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/203963)
4 years, 8 months ago (2016-04-13 00:53:43 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887463002/20001
4 years, 8 months ago (2016-04-13 01:03:07 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 02:14:32 UTC) #13
danakj
ping
4 years, 8 months ago (2016-04-13 18:50:39 UTC) #14
bajones
LGTM but I'm not an owner of platform/graphics. kbr@ is around today, though.
4 years, 8 months ago (2016-04-13 18:57:41 UTC) #15
Ken Russell (switch to Gerrit)
Excellent. LGTM
4 years, 8 months ago (2016-04-13 19:12:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887463002/20001
4 years, 8 months ago (2016-04-13 22:25:19 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 22:34:11 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:36:28 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c01aab9fd28f2f9e6856dca6c243470c39305cd9
Cr-Commit-Position: refs/heads/master@{#387129}

Powered by Google App Engine
This is Rietveld 408576698